-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#25790 Updating type hints to Python3 syntax in pandas/core/array #25829
Merged
Merged
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a0b8c4c
#25790 Updated type hints to Python3 style in files outside core/arrays/
gwrome 46cc909
#25790 Added TypeVar to hint in core/indexes/base.py
gwrome 7acb89a
Fixed reference to types.Tuple that should have been to typing.Tuple
gwrome d9c53ab
Fixed import sort
gwrome e73fe18
#25802 Updated type hints to python3 syntax (array files)
gwrome 545d38d
Removed instance variable type hint for 3.5 compatibility
gwrome abc09fa
Cleaned up array/ type hints
gwrome c37ef88
#25790 Updating type hints to Python3 syntax in pandas/core/array
gwrome ea9c2b3
#25790 Updating type hints to Python3 syntax in pandas/core/array
gwrome 20b63e4
Remove conditional import
gwrome cf774d7
Change forward refs to ABCs
gwrome 50db810
Merge branch 'master' into update-array-type-hints-python3
gwrome 92490a8
Merge branch 'master' into array-type-hints-python3
gwrome 441f4bd
Change forward refs to ABCs
gwrome 33db1ee
Change remaining forward refs to ABCs
gwrome 23aba8a
type to Type
gwrome File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this is a the first stab at ArrayLike (e.g. to put into pandas.typing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a reasonable place to start.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are ok here for now, mainly adding things that we should add
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed this would be great @gwrome do you mind opening up an issue as a follow up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem. I should be able to do that this weekend.