Handle New PyFlakes Issues #25697
Handle New PyFlakes Issues #25697
Conversation
| @@ -16,4 +16,5 @@ pycodestyle: | |||
| - E731, # do not assign a lambda expression, use a def | |||
| - C406, # Unnecessary list literal - rewrite as a dict literal. | |||
| - C408, # Unnecessary dict call - rewrite as a literal. | |||
| - C409 # Unnecessary list passed to tuple() - rewrite as a tuple literal. | |||
| - C409, # Unnecessary list passed to tuple() - rewrite as a tuple literal. | |||
| - F821 # undefined name (temporarily for type hints) | |||
There was a problem hiding this comment.
I'm not actually sure if we want to do this since it would affect all undefined names (not just types) but I couldn't find a way to disambiguate save updating all of the type comments to have an ignore directive. If we wanted to go that route would probably be easier to move forward with some pieces of #25622 but open to thoughts
There was a problem hiding this comment.
That's unfortunate. I think it's probably better to pin to an older flake8 until #25622 is sorted out.
There was a problem hiding this comment.
FWIW, the other changes in this PR seem worthwhile to me, irrespective of what happens with MyPy/F821.
There was a problem hiding this comment.
F821 is a doozy, is one of the checks that frequently catches actual bugs. I’d very much prefer not to ignore it.
There was a problem hiding this comment.
@jbrockmendel for sure. The solution here is tucked away in #25622 so I'll be splitting that out when the timing is right. Waiting for official drop of Py2 in CI before that can happen
Codecov Report
@@ Coverage Diff @@
## master #25697 +/- ##
=======================================
Coverage 91.28% 91.28%
=======================================
Files 173 173
Lines 52967 52967
=======================================
Hits 48351 48351
Misses 4616 4616
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #25697 +/- ##
=======================================
Coverage 91.28% 91.28%
=======================================
Files 173 173
Lines 52967 52967
=======================================
Hits 48351 48351
Misses 4616 4616
Continue to review full report at Codecov.
|
|
Superseded by #25789 |
Had some LINT issues pop up in CI with newest released version of PyFlakes which this should handle