DOC: fix flake8 issue in groupby.rst #24363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc/source/groupby.rst:72:18: F821 undefined name 'obj' doc/source/groupby.rst:72:30: F821 undefined name 'key' doc/source/groupby.rst:73:18: F821 undefined name 'obj' doc/source/groupby.rst:73:30: F821 undefined name 'key' doc/source/groupby.rst:74:18: F821 undefined name 'obj' doc/source/groupby.rst:74:31: F821 undefined name 'key1' doc/source/groupby.rst:74:37: F821 undefined name 'key2'
Codecov Report
@@ Coverage Diff @@
## master #24363 +/- ##
=======================================
Coverage 92.29% 92.29%
=======================================
Files 162 162
Lines 51808 51808
=======================================
Hits 47817 47817
Misses 3991 3991
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24363 +/- ##
==========================================
+ Coverage 92.3% 92.31% +<.01%
==========================================
Files 163 163
Lines 51987 51987
==========================================
+ Hits 47989 47990 +1
+ Misses 3998 3997 -1
Continue to review full report at Codecov.
|
jreback
requested changes
Dec 19, 2018
|
@LJArendse do you have time to address comments of the reviews? |
|
@datapythonista Hi, yes I do. Sorry for the 'radio silence'. |
…after merge with master)" This reverts commit dec7e63.
This reverts commit 41a2e47.
This reverts commit c30f456.
doc/source/groupby.rst:72:18: F821 undefined name 'obj' doc/source/groupby.rst:72:30: F821 undefined name 'key' doc/source/groupby.rst:73:18: F821 undefined name 'obj' doc/source/groupby.rst:73:30: F821 undefined name 'key' doc/source/groupby.rst:74:18: F821 undefined name 'obj' doc/source/groupby.rst:74:31: F821 undefined name 'key1' doc/source/groupby.rst:74:37: F821 undefined name 'key2'
doc/source/groupby.rst
Outdated
|
|
||
| df = pd.DataFrame( | ||
| [('bird', 'Falconiformes', 389.0), | ||
| ('bird', 'Psittaciformes', 24.0), |
There was a problem hiding this comment.
this indentation doesn't seem correct, the opening parenthesis should be at the same level
There was a problem hiding this comment.
Thanks I see, just fixed indentation.
jreback
approved these changes
Dec 27, 2018
|
thanks @LJArendse |
thoo
added a commit
to thoo/pandas
that referenced
this pull request
Dec 28, 2018
* upstream/master: (26 commits) DOC: Fixing doc upload (no such remote origin) (pandas-dev#24459) BLD: for C extension builds on mac, target macOS 10.9 where possible (pandas-dev#24274) POC: _eadata (pandas-dev#24394) DOC: Correct location (pandas-dev#24456) CI: Moving CircleCI build to Travis (pandas-dev#24449) BUG: Infer compression by default in read_fwf() (pandas-dev#22200) DOC: Fix minor typo in whatsnew (pandas-dev#24453) DOC: Add dateutil to intersphinx pandas-dev#24437 (pandas-dev#24443) DOC: Adding links to offset classes in timeseries.rst (pandas-dev#24448) DOC: Adding offsets to API ref (pandas-dev#24446) DOC: fix flake8 issue in groupby.rst (pandas-dev#24363) DOC: Fixing more doc warnings (pandas-dev#24438) API: Simplify repeat signature (pandas-dev#24447) BUG: to_datetime(Timestamp, utc=True) localizes to UTC (pandas-dev#24441) CLN: Cython Py2/3 Compatible Imports (pandas-dev#23940) DOC: Fixing more doc warnings (pandas-dev#24431) DOC: Removing old release.rst (pandas-dev#24427) BUG-24408 Series.dt does not maintain own copy of index (pandas-dev#24426) DOC: Fixing several doc warnings (pandas-dev#24430) ENH: fill_value argument for shift pandas-dev#15486 (pandas-dev#24128) ...
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed flake8 issue in groupby.rst, see Issue #24178 for more info.
The following flake8 'errors' have been fixed: