MAINT: Standardize searchsorted signature #22672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Algos
|
Hello @gfyoung! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #22672 +/- ##
==========================================
- Coverage 92.17% 92.17% -0.01%
==========================================
Files 169 169
Lines 50715 50710 -5
==========================================
- Hits 46747 46742 -5
Misses 3968 3968
Continue to review full report at Codecov.
|
|
If it isn't part of the public API, then I'd say so.
…On Wed, Sep 12, 2018 at 1:23 PM gfyoung ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In doc/source/whatsnew/v0.24.0.txt
<#22672 (comment)>:
> @@ -557,6 +557,7 @@ Deprecations
- :func:`pandas.read_table` is deprecated. Instead, use :func:`pandas.read_csv` passing ``sep='\t'`` if necessary (:issue:`21948`)
- :meth:`Series.str.cat` has deprecated using arbitrary list-likes *within* list-likes. A list-like container may still contain
many ``Series``, ``Index`` or 1-dimensional ``np.ndarray``, or alternatively, only scalar values. (:issue:`21950`)
+- :meth:`FrozenNDArray.searchsorted` has deprecated the ``v`` parameter in favor of ``value`` (:issue:`14645`)
Hmmm...good point. it's not part of the public API. Could we just change
it immediately?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#22672 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIhBfY8IU6Bqh5X29Y2ZVg9GAe5TTks5uaVEPgaJpZM4WkcMY>
.
|
gfyoung
force-pushed
the
frozen-searchsorted
branch
from
8d1b41d to
c162b3b
Compare
gfyoung
changed the title
gfyoung
force-pushed
the
frozen-searchsorted
branch
2 times, most recently
from
f309594 to
4e9e8bc
Compare
|
@TomAugspurger : Change was made, and everything is still green. PTAL. |
|
Hmm, so I looked at where this was actually used In [21]: idx = pd.MultiIndex.from_product([['a', 'b'], [1, 2, 3]])
In [22]: idx.labels[0]
Out[22]: FrozenNDArray([0, 0, 0, 1, 1, 1], dtype='int8')which is, I suppose is close enough to public API that this should be deprecated. Sorry about the misleading comment earlier @gfyoung. |
|
lgtm |
"values" is the law of the land. xref pandas-devgh-14645. Follow-up to pandas-devgh-15601.
gfyoung
force-pushed
the
frozen-searchsorted
branch
from
4e9e8bc to
a0ccac1
Compare
|
@jreback @TomAugspurger : Reverted back to deprecation warning. If no objections, will merge. |
|
ok, pls make sure to add to the deprecations page, otherwise lgtm. |
1 task
aeltanawy
pushed a commit
to aeltanawy/pandas
that referenced
this pull request
Sep 20, 2018
"value" is the law of the land. xref pandas-devgh-14645. Follow-up to pandas-devgh-15601.
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
"value" is the law of the land. xref pandas-devgh-14645. Follow-up to pandas-devgh-15601.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"value" is the law of the land.
xref #14645.
Follow-up to #15601.