DOC: followup to #20583, observed kwarg for .groupby #20941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20941 +/- ##
=======================================
Coverage 91.81% 91.81%
=======================================
Files 153 153
Lines 49479 49479
=======================================
Hits 45428 45428
Misses 4051 4051
Continue to review full report at Codecov.
|
crayxt
reviewed
May 3, 2018
pandas/core/generic.py
Outdated
| if None: if any categorical groupers, show a FutureWarning, | ||
| default to False. | ||
| observed : boolean, default False | ||
| This only applies if any if the groupers are Categoricals |
There was a problem hiding this comment.
if any if the groupers -> if any of the groupers
pandas/core/groupby/groupby.py
Outdated
| if self.observed: | ||
| return result | ||
|
|
||
| # we need to re-expand the output space to accomadate all values |
pandas/core/groupby/groupby.py
Outdated
| return result | ||
|
|
||
| # we need to re-expand the output space to accomadate all values | ||
| # whethere observed or not in the cartesian product of our groupes |
pandas/core/groupby/groupby.py
Outdated
| elif self.observed: | ||
| return result | ||
|
|
||
| # reindexing only appiles to a Categorical grouper |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #20902