Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Skip test_read_excel_parse_dates if no xlwt which is used in to_excel #19803

Merged
merged 1 commit into from
Feb 21, 2018

Conversation

yarikoptic
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 21, 2018

Codecov Report

Merging #19803 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19803      +/-   ##
==========================================
- Coverage   91.61%    91.6%   -0.01%     
==========================================
  Files         150      150              
  Lines       48887    48887              
==========================================
- Hits        44786    44784       -2     
- Misses       4101     4103       +2
Flag Coverage Δ
#multiple 89.98% <ø> (-0.01%) ⬇️
#single 41.8% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 83.64% <0%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 740ad9a...dd910d5. Read the comment docs.

@WillAyd
Copy link
Member

WillAyd commented Feb 21, 2018

FWIW the _skip_if_no_* methods in test_excel.py could all be replaced with the skip_if_no decorator that was introduced in #18765

import pandas.util._test_decorators as td

@td.skip_if_no('xlwt')
def foo(self):
  ...

@td.skip_if_no('xlrd', min_version='0.9')
def bar(self):
  ...

@jreback jreback added Testing pandas testing functions or related to the test suite IO Excel read_excel, to_excel labels Feb 21, 2018
@jreback jreback added this to the 0.23.0 milestone Feb 21, 2018
@jreback jreback merged commit 695614d into pandas-dev:master Feb 21, 2018
@jreback
Copy link
Contributor

jreback commented Feb 21, 2018

thanks @yarikoptic

@WillAyd yep good suggestion. can you open an issue (and PR even better!) for this.

@yarikoptic yarikoptic deleted the bf-noxlwt branch February 21, 2018 17:49
harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Excel read_excel, to_excel Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants