move array_to_datetime timests #19640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Feb 10, 2018
| # test only the iso parser - flexibility to different | ||
| # separators and leadings 0s | ||
| # Timestamp construction falls back to dateutil | ||
| cases = {'2011-01-02': datetime(2011, 1, 2), |
| with pytest.raises(ValueError): | ||
| tslib._test_parse_iso8601(date_str) | ||
| # If no ValueError raised, let me know which case failed. | ||
| raise Exception(date_str) |
There was a problem hiding this comment.
this is not necessary and the point off parametering
There was a problem hiding this comment.
can you remove this except
jreback
added
Testing
Codecov Report
@@ Coverage Diff @@
## master #19640 +/- ##
==========================================
+ Coverage 91.58% 91.61% +0.02%
==========================================
Files 150 150
Lines 48807 48807
==========================================
+ Hits 44702 44714 +12
+ Misses 4105 4093 -12
Continue to review full report at Codecov.
|
jreback
requested changes
Feb 11, 2018
| with pytest.raises(ValueError): | ||
| tslib._test_parse_iso8601(date_str) | ||
| # If no ValueError raised, let me know which case failed. | ||
| raise Exception(date_str) |
There was a problem hiding this comment.
can you remove this except
| result = tslib.array_to_datetime(arr, errors='ignore') | ||
| tm.assert_numpy_array_equal(result, arr) | ||
|
|
||
| @pytest.mark.parametrize('invalid_date', [date(1000, 1, 1), |
jreback
approved these changes
Feb 12, 2018
|
formatting by wrapping near the end of the line is rarely desired. |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost done.
With array_to_datetime there is some fuzziness in when a test is for array_to_datetime and when it is for to_datetime. I'm trying to specifically isolate tslibs tests, so for now am erring on the side of keeping to_datetime tests in test_tools.