Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: set multi_statement flag for pymysql tests #19619

Merged

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Feb 9, 2018

Trying something out for #19462

closes #19462

@pep8speaks
Copy link

pep8speaks commented Feb 9, 2018

Hello @jorisvandenbossche! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on February 09, 2018 at 15:10 Hours UTC

@codecov
Copy link

codecov bot commented Feb 9, 2018

Codecov Report

Merging #19619 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19619   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files         150      150           
  Lines       48795    48795           
=======================================
  Hits        44706    44706           
  Misses       4089     4089
Flag Coverage Δ
#multiple 89.99% <ø> (ø) ⬆️
#single 41.72% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dcc864...9d6cb64. Read the comment docs.

@jreback jreback added IO SQL to_sql, read_sql, read_sql_query Testing pandas testing functions or related to the test suite labels Feb 10, 2018
@jorisvandenbossche jorisvandenbossche added this to the 0.23.0 milestone Feb 11, 2018
@jorisvandenbossche
Copy link
Member Author

Seems to be passing now, so merging.

@jorisvandenbossche jorisvandenbossche merged commit 7a5634e into pandas-dev:master Feb 11, 2018
@jorisvandenbossche jorisvandenbossche deleted the testing-pymysql-flag branch February 11, 2018 22:24
harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018
* Revert "CI: pin pymysql<0.8.0 (pandas-dev#19461)"

This reverts commit 44bbd5a.

* Enable multi-statements for pymysql connection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO SQL to_sql, read_sql, read_sql_query Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: pymysql 0.8.0 compat
3 participants