Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: ASV period #18932

Merged
merged 1 commit into from
Dec 26, 2017
Merged

CLN: ASV period #18932

merged 1 commit into from
Dec 26, 2017

Conversation

mroeschke
Copy link
Member

  • Utilized param for the PeriodProperties benchmark

  • Replaced setup_cache for just setup since only one benchmark was being run for that class.

$ asv dev -b ^period
· Discovering benchmarks
· Running 15 total benchmarks (1 commits * 1 environments * 15 benchmarks)
[  0.00%] ·· Building for existing-py_home_matt_anaconda_envs_pandas_dev_bin_python
[  0.00%] ·· Benchmarking existing-py_home_matt_anaconda_envs_pandas_dev_bin_python
[  6.67%] ··· Running period.Algorithms.time_drop_duplicates                 ok
[  6.67%] ···· 
               ======== ========
                 typ            
               -------- --------
                index    777μs  
                series   7.47ms 
               ======== ========

[ 13.33%] ··· Running period.Algorithms.time_value_counts                    ok
[ 13.33%] ···· 
               ======== ========
                 typ            
               -------- --------
                index    1.33ms 
                series   7.94ms 
               ======== ========

[ 20.00%] ··· Running ...ramePeriodColumn.time_setitem_period_column     80.8ms
[ 26.67%] ··· Running period.Indexing.time_align                         2.57ms
[ 33.33%] ··· Running period.Indexing.time_get_loc                        211μs
[ 40.00%] ··· Running period.Indexing.time_intersection                   516μs
[ 46.67%] ··· Running period.Indexing.time_series_loc                     417μs
[ 53.33%] ··· Running period.Indexing.time_shallow_copy                  53.4μs
[ 60.00%] ··· Running period.Indexing.time_shape                         13.5μs
[ 66.67%] ··· Running ...PeriodIndexConstructor.time_from_date_range         ok
[ 66.67%] ···· 
               ====== =======
                freq         
               ------ -------
                 D     408μs 
               ====== =======

[ 73.33%] ··· Running ...PeriodIndexConstructor.time_from_pydatetime         ok
[ 73.33%] ···· 
               ====== ========
                freq          
               ------ --------
                 D     15.3ms 
               ====== ========

[ 80.00%] ··· Running period.PeriodProperties.time_property                  ok
[ 80.00%] ···· 
               ====== ============== ========
                freq       attr              
               ------ -------------- --------
                 M         year       17.5μs 
                 M        month       17.2μs 
                 M         day        17.4μs 
                 M         hour       17.4μs 
                 M        minute      17.6μs 
                 M        second      16.8μs 
                 M     is_leap_year   17.6μs 
                 M       quarter      17.1μs 
                 M        qyear       17.1μs 
                 M         week       17.8μs 
                 M     daysinmonth    17.7μs 
                 M      dayofweek     16.9μs 
                 M      dayofyear     17.4μs 
                 M      start_time    243μs  
                 M       end_time     263μs  
                min        year       17.4μs 
                min       month       18.5μs 
                min        day        18.1μs 
                min        hour       18.1μs 
                min       minute      18.2μs 
                min       second      18.1μs 
                min    is_leap_year   19.4μs 
                min      quarter      16.7μs 
                min       qyear       17.7μs 
                min        week       18.2μs 
                min    daysinmonth    18.4μs 
                min     dayofweek     18.2μs 
                min     dayofyear     18.2μs 
                min     start_time    242μs  
                min      end_time     260μs  
               ====== ============== ========

[ 86.67%] ··· Running period.PeriodUnaryMethods.time_asfreq                  ok
[ 86.67%] ···· 
               ====== =======
                freq         
               ------ -------
                 M     161μs 
                min    166μs 
               ====== =======

[ 93.33%] ··· Running period.PeriodUnaryMethods.time_now                     ok
[ 93.33%] ···· 
               ====== =======
                freq         
               ------ -------
                 M     128μs 
                min    224μs 
               ====== =======

[100.00%] ··· Running period.PeriodUnaryMethods.time_to_timestamp            ok
[100.00%] ···· 
               ====== =======
                freq         
               ------ -------
                 M     245μs 
                min    242μs 
               ====== =======

@codecov
Copy link

codecov bot commented Dec 24, 2017

Codecov Report

Merging #18932 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18932      +/-   ##
==========================================
- Coverage   91.59%   91.57%   -0.03%     
==========================================
  Files         150      150              
  Lines       48959    48959              
==========================================
- Hits        44843    44833      -10     
- Misses       4116     4126      +10
Flag Coverage Δ
#multiple 89.93% <ø> (-0.03%) ⬇️
#single 41.13% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 65.22% <0%> (-1.74%) ⬇️
pandas/util/testing.py 84.9% <0%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdebcf3...adaeebd. Read the comment docs.

@sinhrks sinhrks added Performance Memory or execution speed performance Period Period data type labels Dec 25, 2017
@jreback jreback added the Benchmark Performance (ASV) benchmarks label Dec 26, 2017
@jreback jreback added this to the 0.23.0 milestone Dec 26, 2017
@jreback jreback merged commit aa84e00 into pandas-dev:master Dec 26, 2017
@jreback
Copy link
Contributor

jreback commented Dec 26, 2017

thanks @mroeschke

how much more to finish linting before can add a rule to auto-lint?

hexgnu pushed a commit to hexgnu/pandas that referenced this pull request Dec 28, 2017
@mroeschke mroeschke deleted the asv_clean_period branch December 31, 2017 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Performance (ASV) benchmarks Performance Memory or execution speed performance Period Period data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants