Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Copy categorical codes if empty (fixes #18051) #18436

Merged
merged 1 commit into from
Nov 23, 2017

Conversation

topper-123
Copy link
Contributor

In agreement with @ghasemnaddaf , I've finished up his PR #18279 (added correct tests). Is it time still to get this into v0.21.1?

@jreback jreback added Bug Categorical Categorical Data Type labels Nov 22, 2017
@jreback jreback added this to the 0.21.1 milestone Nov 22, 2017
@jreback
Copy link
Contributor

jreback commented Nov 22, 2017

lgtm. ping on green.

@topper-123
Copy link
Contributor Author

topper-123 commented Nov 23, 2017

All are green, @jreback .

@codecov
Copy link

codecov bot commented Nov 23, 2017

Codecov Report

Merging #18436 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18436      +/-   ##
==========================================
- Coverage   91.35%   91.34%   -0.02%     
==========================================
  Files         163      163              
  Lines       49681    49691      +10     
==========================================
+ Hits        45386    45388       +2     
- Misses       4295     4303       +8
Flag Coverage Δ
#multiple 89.14% <100%> (ø) ⬆️
#single 39.67% <0%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/categorical.py 95.66% <100%> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.8% <0%> (-0.1%) ⬇️
pandas/io/formats/format.py 96.01% <0%> (ø) ⬆️
pandas/core/reshape/reshape.py 100% <0%> (ø) ⬆️
pandas/core/indexes/multi.py 96.41% <0%> (ø) ⬆️
pandas/core/indexes/datetimes.py 95.49% <0%> (+0.09%) ⬆️
pandas/core/dtypes/missing.py 90.74% <0%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dac9b43...4366126. Read the comment docs.

@jreback jreback merged commit b45325e into pandas-dev:master Nov 23, 2017
@jreback
Copy link
Contributor

jreback commented Nov 23, 2017

thanks @topper-123 keep em coming!

@topper-123
Copy link
Contributor Author

And thanks to @ghasemnaddaf for actually finding and correcting this bug!

@topper-123 topper-123 deleted the catDtype_copy_nan_codes branch November 23, 2017 23:09
@ghasemnaddaf
Copy link
Contributor

ghasemnaddaf commented Nov 23, 2017

urw :-) thx for taking over

TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request Dec 8, 2017
TomAugspurger pushed a commit that referenced this pull request Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Categorical Categorical Data Type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: method .nunique on categorical series in v0.21 with only NaNs gives ValueError
4 participants