-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Copy categorical codes if empty (fixes #18051) #18436
Conversation
lgtm. ping on green. |
All are green, @jreback . |
Codecov Report
@@ Coverage Diff @@
## master #18436 +/- ##
==========================================
- Coverage 91.35% 91.34% -0.02%
==========================================
Files 163 163
Lines 49681 49691 +10
==========================================
+ Hits 45386 45388 +2
- Misses 4295 4303 +8
Continue to review full report at Codecov.
|
thanks @topper-123 keep em coming! |
And thanks to @ghasemnaddaf for actually finding and correcting this bug! |
urw :-) thx for taking over |
…-dev#18436) (cherry picked from commit b45325e)
In agreement with @ghasemnaddaf , I've finished up his PR #18279 (added correct tests). Is it time still to get this into v0.21.1?
git diff upstream/master -u -- "*.py" | flake8 --diff