MAINT: Rename assertRaisesRegexp to assert_raises_regex

[gfyoung]

Title is self-explanatory.

xref #16089 (comment)

[jreback]

assert_raises_regex is a bit shorter

[codecov]

Codecov Report

Merging #16119 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #16119      +/-   ##
==========================================
+ Coverage   90.84%   90.86%   +0.02%     
==========================================
  Files         159      159              
  Lines       50779    50779              
==========================================
+ Hits        46128    46141      +13     
+ Misses       4651     4638      -13

Flag	Coverage Δ
#multiple	88.64% <100%> (+0.02%)	⬆️
#single	40.33% <100%> (ø)	⬆️

Impacted Files	Coverage Δ
pandas/util/testing.py	79.07% <100%> (ø)	⬆️
pandas/core/common.py	91.03% <0%> (+0.34%)	⬆️
pandas/plotting/_converter.py	65.35% <0%> (+1.81%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d50b162...7a58c30. Read the comment docs.

[gfyoung]

I was thinking the "with" makes the name a little clearer (from a grammatical perspective especially). What do you think?

[jreback]

with tm.assert_raises_with_regex(
                 ValueError, "\"mysin\" is not a supported function"):

This is much more clear (and not redundant).

with tm.assert_raises_regex(
                 ValueError, "\"mysin\" is not a supported function"):

[gfyoung]

Fair enough. Done.

[gfyoung]

@jreback : It would be great to get this merged in ASAP, since every time master gets updated, I have to rebase (like I have to now) to ensure that there are no merge conflicts + no new assertRaisesRegexp have been used.

[jreback]

yes, sorry, busy with some other things.

thanks @gfyoung

[gfyoung]

@jreback : No worries, but FYI, master is going to break because I was just going to remove the remain assertRaisesRegexp from the latest commits before you merged.

[gfyoung]

@jreback : Putting up PR right now to patch this immediately.

[jreback]

yep