TST: convert yield based test_pickle.py to parametrized to remove warnings #15416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
commented
Feb 15, 2017
pandas/tests/io/test_pickle.py
Outdated
| # if available | ||
| comparator = "compare_{typ}_{dt}".format(typ=typ, dt=dt) | ||
|
|
||
| m = sys.modules['pandas.tests.io.test_pickle'] |
There was a problem hiding this comment.
any better way to do this?
There was a problem hiding this comment.
actually using globals() I think is the right way
jreback
force-pushed
the
warn
branch
3 times, most recently
from
8d70122
to
ea6009a
Compare
Codecov Report
@@ Coverage Diff @@
## master #15416 +/- ##
==========================================
+ Coverage 90.36% 90.36% +<.01%
==========================================
Files 135 135
Lines 49438 49438
==========================================
+ Hits 44675 44677 +2
+ Misses 4763 4761 -2
Continue to review full report at Codecov.
|
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
…nings xref pandas-dev#15341 Author: Jeff Reback <[email protected]> Closes pandas-dev#15416 from jreback/warn and squashes the following commits: a6af576 [Jeff Reback] TST: convert yield based test_pickle.py to parametrized to remove warnings xref pandas-dev#15341
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #15341