BUG: #14016. Preserve categorical keys through concat #14035
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1637,7 +1640,10 @@ def _make_concat_multiindex(indexes, keys, levels=None, names=None): | |||
| else: | |||
| levels = [_ensure_index(x) for x in levels] | |||
| else: | |||
| zipped = [keys] | |||
| if isinstance(keys, cat.CategoricalIndex): | |||
| zipped = lzip(*keys) | |||
There was a problem hiding this comment.
this is way too special casey; needs a more general soln.
There was a problem hiding this comment.
I do agree, but not obvious to me what it should be
jreback
added
Reshaping
|
can you rebase / update? |
|
can you rebase / update |
|
can you rebase? |
jreback
reviewed
Dec 26, 2016
| @@ -1367,7 +1367,10 @@ def __init__(self, objs, axis=0, join='outer', join_axes=None, | |||
| clean_keys.append(k) | |||
| clean_objs.append(v) | |||
| objs = clean_objs | |||
| keys = clean_keys | |||
| if isinstance(keys, cat.CategoricalIndex): | |||
There was a problem hiding this comment.
needs a rebase, but I think this would almost work as-is, as IIRC we do something like
keys = _ensure_index(keys) already
|
rebase this, some other changes may have fixed / made this easier. |
|
can you rebase / update? |
|
can you rebase |
|
closing as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff