Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: test_object_factorize_dropna failing in MacPython/pandas-wheels #34130

Closed
TomAugspurger opened this issue May 12, 2020 · 2 comments · Fixed by #34135
Closed

CI: test_object_factorize_dropna failing in MacPython/pandas-wheels #34130

TomAugspurger opened this issue May 12, 2020 · 2 comments · Fixed by #34135
Labels
32bit 32-bit systems Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff CI Continuous Integration
Milestone

Comments

@TomAugspurger
Copy link
Contributor

https://dev.azure.com/pandas-dev/pandas-wheels/_build/results?buildId=35317&view=logs&j=79f3a53a-4a6d-509c-98b5-ff6e9111f67c&t=25a63239-9c30-5cf0-cb4c-3d01da7b47c5

    def test_object_factorize_dropna(
        self, data, dropna, expected_codes, expected_uniques
    ):
        codes, uniques = algos.factorize(data, dropna=dropna)
    
        tm.assert_numpy_array_equal(uniques, expected_uniques)
>       tm.assert_numpy_array_equal(codes, expected_codes)
E       AssertionError: numpy array are different
E       
E       Attribute "dtype" are different
E       [left]:  int32
E       [right]: int64

I'm not sure what the correct behavior is here, but the implementation is returning int32 while we're asserting int64. The test should probably check for np.dtype("intp").

@TomAugspurger TomAugspurger added CI Continuous Integration Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff 32bit 32-bit systems labels May 12, 2020
@TomAugspurger TomAugspurger added this to the 1.0.4 milestone May 12, 2020
TomAugspurger added a commit to TomAugspurger/pandas that referenced this issue May 12, 2020
@charlesdong1991
Copy link
Member

emm, yeah this was brought in #30584 and i did observe issues with dtypes in windows machine, that's why to force to int64 back then, but probably should better use intp .

btw, i think this should have milestone for 1.1? since the pr that brought this issue has the 1.1 milestone.

@TomAugspurger
Copy link
Contributor Author

Thanks, good call on the milestone.

@TomAugspurger TomAugspurger modified the milestones: 1.0.4, 1.1 May 12, 2020
jreback pushed a commit that referenced this issue May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
32bit 32-bit systems Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff CI Continuous Integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants