Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ArrayLike an Dtype definitions to pandas._typing #25942

Closed
2 tasks
gwrome opened this issue Mar 31, 2019 · 0 comments · Fixed by #25943
Closed
2 tasks

Add ArrayLike an Dtype definitions to pandas._typing #25942

gwrome opened this issue Mar 31, 2019 · 0 comments · Fixed by #25943
Labels
Typing type annotations, mypy/pyright type checking
Milestone
0.25.0

Comments

@gwrome
Copy link
Contributor

gwrome commented Mar 31, 2019

The existing type hints in the codebase suggest a couple of easy additions to the pandas._typing module, including

  • ArrayLike = Union[ABCExtensionArray, np.ndarray] and
  • Dtype = Union[str, np.dtype, ExtensionDtype, Type].

These should be added to the typing module and the matching types replaced with the newly defined ones where they occur.

Crossreferences: #25829 and #25791.
gwrome added a commit to gwrome/pandas that referenced this issue Mar 31, 2019
@gwrome
pandas-dev#25942 Added ArrayLike and Dtype to pandas._typing
0761dab
@gwrome gwrome mentioned this issue Mar 31, 2019
Merged
2 tasks
@WillAyd WillAyd added the Typing type annotations, mypy/pyright type checking label Mar 31, 2019
@jreback jreback added this to the 0.25.0 milestone Apr 1, 2019
@gwrome gwrome mentioned this issue Apr 9, 2019
Merged
3 tasks
jreback pushed a commit that referenced this issue Apr 10, 2019
@gwrome @jreback
#25942 Added ArrayLike and Dtype to pandas._typing (#25943)
6d9b702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
0.25.0
Development

Successfully merging a pull request may close this issue.

#25942 Added ArrayLike and Dtype to pandas._typing gwrome/pandas
3 participants
@WillAyd @jreback @gwrome