Make Stata.data_label method a property

pandas-dev · Apr 4, 2019 · df8beec · df8beec
1 parent df41bdb
commit df8beec
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/pandas/io/stata.py b/pandas/io/stata.py
@@ -1731,11 +1731,12 @@ def _do_convert_categoricals(self, data, value_label_dict, lbllist,
         data = DataFrame.from_dict(OrderedDict(cat_converted_data))
         return data
 
+    @property
     def data_label(self):
         """
         Return data label of Stata file.
         """
-        return self.data_label
+        return self._data_label
 
     def variable_labels(self):
         """

diff --git a/pandas/tests/io/test_stata.py b/pandas/tests/io/test_stata.py
@@ -301,7 +301,7 @@ def test_read_dta18(self):
                            'Floats': 'float data'}
             tm.assert_dict_equal(vl, vl_expected)
 
-            assert rdr._data_label == 'This is a  Ünicode data label'
+            assert rdr.data_label == 'This is a  Ünicode data label'
 
     def test_read_write_dta5(self):
         original = DataFrame([(np.nan, np.nan, np.nan, np.nan, np.nan)],
@@ -499,7 +499,7 @@ def test_timestamp_and_label(self, version):
 
             with StataReader(path) as reader:
                 assert reader.time_stamp == '29 Feb 2000 14:21'
-                assert reader._data_label == data_label
+                assert reader.data_label == data_label
 
     @pytest.mark.parametrize('version', [114, 117])
     def test_invalid_timestamp(self, version):