-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pandas 2.2; remove some deprecated behavior; update black+pyright #860
Conversation
| MaskType | ||
| tuple[IndexType | MaskType, IndexType | MaskType] | ||
| tuple[slice] | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Not too keen on the new formatting)
fix black issue do to merging with main
remove blank line due to resolving merge conflict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @twoertwein .
I had to resolve some merge conflicts.
Thank you for taking care of the conflicts! Can probably have a new release - or wait for the open PRs! |
I'm going to wait for the open PR's. Will you see if you can get nightly working? |
I think I can get that done this evening. How do we want to handle breaking changes in 3.0 (that do not warn on 2.2 but fail on 3.0)? Ignore in the CI or proactively remove them from the stubs? I'm fine with either. |
Don't change the stubs for nightly. Just change the In PD_LTE_21 = Version(pd.__version__) < Version("2.1.999") So you'd change that to now be |
Also reduced the number of failures on nightly, but it still fails.
I should have put the black changes in a different commit, but I realized that too late.
edit: run black on a new branch, rebased, and force pushed to separate black and the other changes