Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine iterrows and itertuples return types #822

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Refine iterrows and itertuples return types #822

merged 1 commit into from
Dec 1, 2023

Conversation

lebaudantoine
Copy link
Contributor

@lebaudantoine lebaudantoine commented Dec 1, 2023 •
edited
Loading

Based on @Dr-Irv suggestion:

@lebaudantoine
refine iterrows and itertuples return types
aca5f3c 
* Added first test on iterrows.
* Updated iterrows return type to Iterable[tuple[Hashable, Series]].
* Added return type Iterable[tuple[Any, ...]] to itertuples.
@lebaudantoine lebaudantoine marked this pull request as ready for review December 1, 2023 13:38
@lebaudantoine lebaudantoine mentioned this pull request Dec 1, 2023
Closed
Dr-Irv
Dr-Irv approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @lebaudantoine

@Dr-Irv Dr-Irv merged commit 2aadf0e into pandas-dev:main Dec 1, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add types for DataFrame.itertuples() and DataFrame.iterrows()
2 participants
@lebaudantoine @Dr-Irv