Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH: 624 - Added dtype_backend to all read_* functions #655

Merged
merged 14 commits into from
Apr 24, 2023
Merged

GH: 624 - Added dtype_backend to all read_* functions #655

merged 14 commits into from
Apr 24, 2023

Conversation

ramvikrams
Copy link
Contributor

@ramvikrams ramvikrams commented Apr 21, 2023 •
edited
Loading

@ramvikrams ramvikrams changed the title GH: 624 - Added dtype_backend to all functions GH: 624 - Added dtype_backend to all read_* functions Apr 21, 2023
Dr-Irv
Dr-Irv requested changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just some re-ordering to do

pandas-stubs/core/series.pyi Outdated Show resolved Hide resolved
pandas-stubs/io/clipboards.pyi Outdated Show resolved Hide resolved
pandas-stubs/io/parsers/readers.pyi Outdated Show resolved Hide resolved
Dr-Irv
Dr-Irv requested changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found a couple other things

tests/test_io.py Outdated Show resolved Hide resolved
tests/test_io.py Outdated Show resolved Hide resolved
@ramvikrams ramvikrams requested a review from Dr-Irv April 22, 2023 14:49
Dr-Irv
Dr-Irv reviewed Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Had one question on a test.

tests/test_io.py Show resolved Hide resolved
Dr-Irv
Dr-Irv approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ramvikrams

@Dr-Irv Dr-Irv merged commit c67da63 into pandas-dev:main Apr 24, 2023
@ramvikrams ramvikrams deleted the t220 branch April 24, 2023 17:56
@Dr-Irv Dr-Irv mentioned this pull request Apr 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version 2.0 Compatibility Tracker
2 participants
@ramvikrams @Dr-Irv