Make it a composer project so it can, you know, work... #1
Conversation
| @@ -0,0 +1,2 @@ | |||
| /vendor/ | |||
There was a problem hiding this comment.
That's how the composer init command sets it, but ¯\_(ツ)_/¯
There was a problem hiding this comment.
Then should the idea/ directory be the same: .idea*?
I think I prefer how it is now, you're trying to exclude the directory, you don't need a wildcard
src/ErrorCatalog.php
Outdated
| * @param $namespace | ||
| * @param string $language | ||
| */ | ||
| public function __construct($namespace, $language = 'en-US') |
There was a problem hiding this comment.
$this->language = $language
src/ErrorCatalog.php
Outdated
| * @return ErrorCatalogItem | ||
| */ | ||
| public function getItem($name) |
There was a problem hiding this comment.
What should this method return if it doesn't find the item?
There was a problem hiding this comment.
for now, return null;. Maybe we should add a default at a later stage
src/ErrorSpecIssue.php
Outdated
| /** | ||
| * @var string The JSON pointer to identify the issue | ||
| */ | ||
| protected $jsonPointer; |
There was a problem hiding this comment.
It's not really a json pointer though is it? What exactly is this extra identifier?
There was a problem hiding this comment.
Maybe call this reference
| @@ -0,0 +1,2 @@ | |||
| /vendor/ | |||
src/ErrorSpecIssue.php
Outdated
| /** | ||
| * @var string The JSON pointer to identify the issue | ||
| */ | ||
| protected $jsonPointer; |
There was a problem hiding this comment.
Maybe call this reference
src/ErrorCatalog.php
Outdated
| * @return ErrorCatalogItem | ||
| */ | ||
| public function getItem($name) |
There was a problem hiding this comment.
for now, return null;. Maybe we should add a default at a later stage
No description provided.