Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade SDK v0.47 to v0.50 #1069

Merged
merged 58 commits into from
Feb 27, 2024
Merged

feat: Upgrade SDK v0.47 to v0.50 #1069

merged 58 commits into from
Feb 27, 2024

Conversation

deepan95dev
Copy link
Contributor

@deepan95dev deepan95dev commented Dec 28, 2023

Related Github tickets

  • Upgrading SDK v0.47.4 to v0.50.2

Background

This PR contains all the changes that has to be done for the upgrade, including integration tests/unit tests. This also contains latest master branch commits upto this

Testing completed

  • keeper_integration_tests are moved to tests/integration/{module} with local fixture setup, leaving the dependency on app/app_setup.go (so the file app_setup.go is deleted)
  • New test cases added are
  • util/keeper/address_test.go which covers util/keeper/address.go
  • /x/gravity/migrations/v1/migrate_test.go which covers /x/gravity/migrations/v1/migrate.go
  • Most of the test coverage exists as it is with upgrade related changes, only few got updated as listed below
  • tests/integration/evm/keeper/keeper_integration_test.go had putMessageInQueue in the case there is another upload valset already in only but later we needed to add for two more functions, TestFirstSnapshot_OnSnapshotBuilt() function and TestOldPublishedSnapshot_OnSnapshotBuilt function
  • In x/paloma/ante.go after a series of discussion we arrived at the conclusion to use libmeta.getSigner but the test cases were failing so I mentioned here with comment, you may interpret this change to adapt with the test case.
  • tested in a private testnet
  • Upgrade testing is done

Breaking changes

  • I have checked my code for breaking changes
  • If there are breaking changes, there is a supporting migration.

Base automatically changed from paloma-changes to v0.50.0-upgrade January 9, 2024 11:20
app/app.go Outdated Show resolved Hide resolved
@deepan95dev deepan95dev changed the base branch from v0.50.0-upgrade to master January 16, 2024 09:15
@deepan95dev deepan95dev changed the title fix: build fixes feat: Upgrade SDK v0.47 to v0.50 Jan 16, 2024
@deepan95dev deepan95dev marked this pull request as ready for review January 16, 2024 09:21
Copy link
Contributor

@byte-bandit byte-bandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this until I find some time to step through all the changes. Other than code review, there's a few things missing here:

  • Rebase on latest version of master
  • PR description including short description & already performed tests
  • before these changes are added to master, we need full E2E testing including compatibility with Paloma's side loading app Pigeon. We can compile a list of manual testing steps required to pass successfully before we consider going ahead.

@deepan95dev
Copy link
Contributor Author

Blocking this until I find some time to step through all the changes. Other than code review, there's a few things missing here:

  • Rebase on latest version of master
  • PR description including short description & already performed tests
  • before these changes are added to master, we need full E2E testing including compatibility with Paloma's side loading app Pigeon. We can compile a list of manual testing steps required to pass successfully before we consider going ahead.

How shall we proceed with E2E testing with Paloma's Pigeon App?

@byte-bandit
Copy link
Contributor

How shall we proceed with E2E testing with Paloma's Pigeon App?

@taariq @verabehr @aleem1314

I suggest Volume compiles a list of manual testing steps and required proof of verification to share with the vitwit team. Happy to drive this on Notion until we settle on a run book.

Copy link
Contributor

@byte-bandit byte-bandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions regarding proto changes.

proto/palomachain/paloma/consensus/tx.proto Show resolved Hide resolved
proto/palomachain/paloma/gravity/msgs.proto Show resolved Hide resolved
proto/palomachain/paloma/valset/common.proto Show resolved Hide resolved
util/liblog/liblog.go Show resolved Hide resolved
Copy link

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1st round of feedback

app/export.go Outdated Show resolved Hide resolved
app/export.go Outdated Show resolved Hide resolved
cmd/palomad/config.go Show resolved Hide resolved
proto/palomachain/paloma/consensus/tx.proto Show resolved Hide resolved
proto/palomachain/paloma/consensus/tx.proto Outdated Show resolved Hide resolved
x/scheduler/module.go Outdated Show resolved Hide resolved
x/treasury/keeper/params.go Show resolved Hide resolved
x/valset/keeper/keeper.go Outdated Show resolved Hide resolved
x/valset/keeper/keeper.go Show resolved Hide resolved
x/valset/keeper/keeper_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@byte-bandit byte-bandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only small stuff remaining, but most of it we'll just accept for now.

Can you please also run a full scan over the code base and make sure there's no other occurrances of CacheContext() that slipped through the renaming?

x/evm/keeper/attest.go Outdated Show resolved Hide resolved
x/evm/keeper/attest.go Outdated Show resolved Hide resolved
x/gravity/keeper/keeper.go Show resolved Hide resolved
x/gravity/types/msgs.go Show resolved Hide resolved
x/metrix/keeper/keeper.go Outdated Show resolved Hide resolved
x/metrix/module.go Outdated Show resolved Hide resolved
Copy link
Contributor

@byte-bandit byte-bandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final review to @aleem1314

app/app.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
app/upgrades.go Outdated Show resolved Hide resolved
Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre approving

@taariq
Copy link
Contributor

taariq commented Feb 26, 2024

@aleem1314 we have just TWO unresolved convos on the PR. We will merge on your check and resolve.

@byte-bandit byte-bandit merged commit a4b1e22 into master Feb 27, 2024
2 checks passed
@byte-bandit byte-bandit deleted the fix-build branch February 27, 2024 16:23
@faddat
Copy link

faddat commented Mar 1, 2024

Just wanted to say that I thought this is cool :-)

@taariq
Copy link
Contributor

taariq commented Mar 1, 2024

Just wanted to say that I thought this is cool :-)

That means so much to us @faddat! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants