Added support for Reschedule api as well. For Users who wants to reschedule booking rather fresh booking for 1st dose.

[vsachinv]

No description provided.

[catch-n-release]

Hey, the current code works for rescheduling as is. You can try it.
This would just increase lines for a functionality that's already present.

[pallupz]

@catch-n-release : current code does not provide rescheduling option

[pallupz]

@vsachinv - Thank you for the PR! If I understand this correctly, to reschedule an appointment, a slot has to be available in the first place. So why not cancel and book?

[catch-n-release]

@pallupz If rescheduling is booking a new appointment for a beneficiary already having one, then the current code does, even if it's not explicit functionality. It's tested.

[catch-n-release]

@pallupz Please correct me if I have a wrong understanding.😅

[pallupz]

@catch-n-release I agree that this may not be a necessary feature. I think the idea is to book another slot without having to go into the portal and canceling existing one manually.

[catch-n-release]

@pallupz I totally agree. But one doesn't even have to cancel the appointment. It books a new appointment for the same beneficiary (if not vaccinated). I think you have underestimated the power of your own code 😆. I can cross-check and send my findings to you. But then again, your call totally. 😁

[pallupz]

oh thats interesting.. I hadn't tested it that way. So if we have already have an appointment, and try to book another one, it essentially works like canceling and booking? I thought that might throw some error. Can't help but wonder what was the point for this reschedule endpoint then?!

[vsachinv]

@catch-n-release I have checked. it doesn't work if already schedule exist in the current code as it hits only schedule api not reschedule api. It fails. Due to this i couldn't book :( . Due that only i came up with changes :) .
@pallupz Looks like cancel scheduled slot is not working. Even portal has not given cancel option only rescheduling is there.

Check below response

================================= ATTEMPTING BOOKING ==================================================
Booking Response Code: 400
Booking Response : {"errorCode":"APPOIN0022","error":"An active first dose appointment already exists for the individual with reference id 33424062792331"}
Response: 400 : {"errorCode":"APPOIN0022","error":"An active first dose appointment already exists for the individual with reference id 33424062792331"}

[pallupz]

@vsachinv - The portal does have cancel option but the design makes is super hard to find. For each beneficiary's section, who have an active appointment, there's a tiny 'x' button on the right top corner

[pallupz]

Nonetheless, this sort of a serious change. Will merge to another branch (not main) and test in the weekend.

[pallupz]

Could you please raise this to ext-dev/reschedule branch?

[vsachinv]

@pallupz Sure and thanks i will check that cancel option as well.

[pallupz]

I have no idea why they designed it so. Should've gone with a proper red button with actual text.

[pallupz]

I ran through the changes. Since the details needed are almost the same, what if instead of creating a separate function for rescheduling, we try to incorporate it into booking itself? That way we may be able to avoid a bunch of code duplication.

[vsachinv]

@pallupz thanks. Now, I am able to cancel the slot from cowin. Yeah its not intuitive for cancel and also from Arogya Setu app on cancelling it was giving API error. Nevertheless thanks for helping me :). I have changed branch PR to ext-dev/reschedule as well.

[pallupz]

I haven't gone through in detail so not sure if that'd be possible.

[pallupz]

Essentially, if someone with active appointment tries to book, code will utilize Rescheduling endpoint. Otherwise, it will go with Booking endpoint.

[catch-n-release]

@vsachinv That's strange! I got people to reschedule 3 days ago without facing that error. Could you tell me when did you last try rescheduling?
Anyway, If @pallupz thinks it's good I have no more questions/doubts about it.

[pallupz]

maybe @vsachinv is trying for second dose. I'm considering implementing it because the portal UI is not all intuitive.

[vsachinv]

@pallupz No i was trying for first dose only just i didn't cancel existing appointments only. One of the appointment was of past date.

[vsachinv]

@pallupz I didn't see any code of reschedule for already existing appointments. How it was using reschedule if appointment already exists? @catch-n-release I was trying on 19th May.