Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Parser #1851

Closed
wants to merge 4 commits into from
Closed

Configurable Parser #1851

wants to merge 4 commits into from

Conversation

hasier
Copy link

@hasier hasier commented May 22, 2023

Adds a class-variable to Parser so that subclasses can override which keywords the parser will recognise.
Similarly, adds a class-variable to Environment so that subclasses can override which Parser they'll use.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@hasier
Copy link
Author

hasier commented May 22, 2023

The test failing in 3.12-dev seems to also be failing in main, so it does not seem related to the changes here. Same issue in other repos:

@davidism davidism closed this May 22, 2023
@davidism davidism reopened this May 22, 2023
@davidism davidism closed this May 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable Parser
2 participants