Update typing #4042
Merged
Update typing #4042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgjones
approved these changes
May 13, 2021
|
This fixes the CI failure on the LVFS. Thanks! |
lucaswerkmeister
added a commit
to lucaswerkmeister/tool-ranker
that referenced
this pull request
May 15, 2021
> app.py:573: error: "AppContext" has no attribute "setdefault" This is a workaround for a type bug introduced in Flask 2.0.0 (already fixed in pallets/flask#4042 [1], but 2.0.1 not yet released). [1]: pallets/flask#4042
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gand tell mypy it's a namespace. fixes Assigning to attribute flask.g.[...] not defined in class slots (assigning-non-slot) #4020Checklist:
CHANGES.rstsummarizing the change and linking to the issue.pre-commithooks and fix any issues.pytestandtox, no tests failed.