Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blueprint route for "" #2748

Merged
merged 2 commits into from
May 2, 2018
Merged

Fix blueprint route for "" #2748

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7a3bdc
Fix blueprint route for ""
lepture May 1, 2018
b21b4d1
add more merge cases
davidism May 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion flask/blueprints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,10 @@ def add_url_rule(self, rule, endpoint=None, view_func=None, **options):
blueprint's name.
"""
if self.url_prefix is not None:
rule = '/'.join((self.url_prefix, rule.lstrip('/')))
if rule:
rule = '/'.join((self.url_prefix, rule.lstrip('/')))

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

else:
rule = self.url_prefix
options.setdefault('subdomain', self.subdomain)
if endpoint is None:
endpoint = _endpoint_from_view_func(view_func)
Expand Down
1 change: 1 addition & 0 deletions tests/test_blueprints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ def bp_forbidden():


@pytest.mark.parametrize(('prefix', 'rule', 'url'), (
('/foo', '', '/foo'),
('/foo/', '/bar', '/foo/bar'),
('/foo/', 'bar', '/foo/bar'),
('/foo', '/bar', '/foo/bar'),
Expand Down