Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating contributing rst #2305

Merged
merged 2 commits into from May 23, 2017
Merged

Updating contributing rst #2305

merged 2 commits into from May 23, 2017

Conversation

ghost
Copy link

@ghost ghost commented May 23, 2017

No description provided.

ghost
ghost suggested changes May 23, 2017
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these points are not needed in contribution guide, these are common things to consider and understood.
Still need your point of view on this.

Thanks!

CONTRIBUTING.rst Outdated
- `Set up your username in git
<https://help.github.com/articles/setting-your-username-in-git/>`_
- `Set up your email in git
<https://help.github.com/articles/setting-your-email-in-git/>`_

This comment was marked as off-topic.

Sign in to view

@davidism davidism merged commit 54a18a5 into pallets:master May 23, 2017
@ghost ghost deleted the updating_contributing_rst branch May 24, 2017 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidism @sorech02