-
-
Notifications
You must be signed in to change notification settings - Fork 16.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
turn on autoescape for flask.templating.render_template_string #1515
Conversation
Could you shorten the commit msg a bit? It's so long that github truncates
it. Usually the first line should be 51 chars or less (with the 2nd line
being empty and anything else in the following lines (max 72 chars per line)
|
@ThiefMaster sure, done. What's the eta on this getting merged, I have other pull requests I would like to submit as well. |
@@ -1460,7 +1460,7 @@ def handle_http_exception(self, e): | |||
# those unchanged as errors | |||
if e.code is None: | |||
return e | |||
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
I'm not sure how, but I think the current behavior should be better documented. |
In addition to some docs, could you add a changelog and a note in the Upgrading document? |
I've updated the docstring which will show up in this doc, but I should regenerate docs or add more info somewhere? For changelog, should I add to version 0.10.2 or 1.0? |
1.0 |
Finished all the changes, everything looks good? |
I would squash all the commits (besides the whitespace fixes) into a single one for the message i'd use e.g. this:
that way you stay below 51 chars and it's still clear what it changes |
I've pinged mitsuhiko on IRC if there's a good reason for the current behavior. I assume not and will merge this if he doesn't respond. |
@ThiefMaster squashed. |
thanks! (and oops, looks like i forgot the trailing backtick in the commit message suggestion) |
Thanks, rebased and merged! |
Previous pull request was #1176