Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to reflect deprecated ext format #1366

Closed
wants to merge 3 commits into from
Closed

Update docs to reflect deprecated ext format #1366

wants to merge 3 commits into from

Conversation

keyan
Copy link
Contributor

@keyan keyan commented Mar 7, 2015

Update docs so extension developers are urged to use the new import format in preparation for removing the magic .ext redirection tool. See #1135.

@untitaker
Copy link
Contributor

By the time these docs will get published, the ext format will already be deprecated or even gone.

@keyan
Copy link
Contributor Author

keyan commented Mar 7, 2015

@untitaker Are you suggesting not making the documentation changes at all or just changing to wording to reflect that the ext format will already have been removed?

namespace packages. See :ref:`ext-import-transition` for more details.
their :file:`setup.py` files. If you for instance have a package called
``flask_something`` users should import it as ``flask_something`` rather than
using the soon to deprecated format ``flask.ext.something``. See

This comment was marked as off-topic.

@untitaker
Copy link
Contributor

Also, time to mention your migration tool? :)

BTW thanks for putting so much work into this!

@keyan
Copy link
Contributor Author

keyan commented Mar 7, 2015

I changed the tense and altered the wording a bit. Additionally I wrote a little about using the tool, although I was not sure if a direct reference to the location of the script in the repo was appropriate as this might change?

No problem, my pleasure to help out. Side note, is there any way to get privileges to close/re-open issues? I'd like to help clean up the issue tracker, but don't want to bother you or DasIch every time. Thanks!

@keyan
Copy link
Contributor Author

keyan commented Mar 7, 2015

Actually, I realize I need to add details to setup.py so users can invoke the script. I need to read more about this, I'll make a new commit when it's ready.

@untitaker
Copy link
Contributor

Thanks for wanting to help... mitsuhiko can give you those permissions.

@untitaker
Copy link
Contributor

Ask him on the pocoo IRC channel

@untitaker
Copy link
Contributor

Blocked by #1367, but as written there, I think the redbaron dependency should be informally documented and not be coded into the setup.py

@untitaker
Copy link
Contributor

I've rewritten this and ended up with #1484. Thanks for the work so far @keyan, especially for the migration tool!

@untitaker untitaker closed this Jun 6, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants