Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and remove APIs #1182

Closed
6 tasks done
methane opened this issue Sep 19, 2014 · 12 comments
Closed
6 tasks done

Deprecate and remove APIs #1182

methane opened this issue Sep 19, 2014 · 12 comments
Milestone

Comments

@methane
Copy link
Contributor

methane commented Sep 19, 2014

@untitaker untitaker added this to the 1.0 milestone Sep 19, 2014
@untitaker
Copy link
Contributor

I updated the OP as a meta issue tracking all API changes for 1.0.

@untitaker untitaker changed the title Remove deprecated APIs Deprecate and remove APIs Oct 19, 2014
sh4nks added a commit to flaskbb/flaskbb that referenced this issue Jan 8, 2015
Gonna be deprecated with 1.0 anyway so better do it now.
Follow this link for more information:
pallets/flask#1182
@untitaker
Copy link
Contributor

#1291 just got merged, and after doing most of the API breakages, I'd like to make some sort of alpha for Flask 1.0.

@ThiefMaster
Copy link
Member

Would it make sense to remove the deprecated Flask.modules property, too?

@untitaker
Copy link
Contributor

Thought it was already removed! PRs welcome.

On 20 June 2015 18:06:30 CEST, Adrian [email protected] wrote:

Would it make sense to remove the deprecated Flask.modules property,
too?


Reply to this email directly or view it on GitHub:
#1182 (comment)

@ThiefMaster
Copy link
Member

#1510

@jeffwidman
Copy link
Contributor

Allow all objects in json

This was fixed in #1671

@jeffwidman
Copy link
Contributor

deprecate flask.ext

I marked this as fixed by #1484.

@autoferrit
Copy link
Contributor

Working on this in the pycon sprint

@autoferrit
Copy link
Contributor

In regards to the removal or deprecation of the *_session methods, can you elaborate on why those should be deprecated or removed? I searched the code base and they don't seem to be deprecated already. So It appears we need to do that first. I also looked around with @davidism at the pycon sprints and we could not figure out why they needed to be removed or deprecated, or why.

@davidism
Copy link
Member

davidism commented Jun 4, 2016

remove support for name guessing from send_file #1427

#1849

@davidism
Copy link
Member

davidism commented Jun 4, 2016

@untitaker did you add the "remove *_session" task? What were you referring to?

@methane
Copy link
Contributor Author

methane commented Jun 4, 2016

I meant make_null_session, open_session and save_session in Flask class.
session_interface is recommended way.

But I notice they aren't marked as deprecated for now.
So we can't remove them. How about start deprecating?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants