Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly bind names in __init__.py #1880

Closed
wants to merge 1 commit into from
Closed

Conversation

tucked
Copy link

@tucked tucked commented May 11, 2021

Resolve #1879

This is just a start... I have a presentation to give at 4PM PDT, then I'll come back and spend more time with this.

  • fixes #

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism
Copy link
Member

davidism commented May 11, 2021

This is noisy, I don't plan to make this change. You can add the following config to your project to allow Click (or other packages) to do this, it's a very common pattern. I suggest you have further discussion with mypy about the strictness of this, it sounds like they're open to it or may already have an open issue about it.

[mypy-click]
no_implicit_reexport = False

@tucked
Copy link
Author

tucked commented May 12, 2021

may already have an open issue about it

Looks like python/mypy#10198 applies.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2021
@tucked tucked deleted the issue1879 branch June 20, 2022 22:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Click 8.0 does not support mypy's no_implicit_reexport
2 participants