Flask Session removal

[supreme-core]

I am getting errors when the flask application exits and the context are popped off.

    @pytest.fixture(scope="session")
    def app():
        """CEUI app pytest fixture."""
        _app = create_app()
        ctx = _app.app_context()
        ctx.push()
    
        yield _app
    
>       ctx.pop()

tests/conftest.py:57: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
venv/lib/python3.8/site-packages/flask/ctx.py:253: in pop
    self.app.do_teardown_appcontext(exc)
venv/lib/python3.8/site-packages/flask/app.py:2402: in do_teardown_appcontext
    self.ensure_sync(func)(exc)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <SQLAlchemy>, exc = None

    def _teardown_session(self, exc: BaseException | None) -> None:
        """Remove the current session at the end of the request.
    
        :meta private:
    
        .. versionadded:: 3.0
        """
>       self.session.remove()
E       AttributeError: 'Session' object has no attribute 'remove'

venv/lib/python3.8/site-packages/flask_sqlalchemy/extension.py:448: AttributeError

Flask                    2.2.5   
Flask-Assets             2.1.0   
flask-babel              4.0.0   
Flask-Login              0.6.3   
Flask-Mail               0.9.1   
Flask-Migrate            4.0.7   
Flask-Moment             1.0.5   
Flask-Paranoid           0.3.0   
flask-sqlalchemy         3.1.0   
SQLAlchemy               2.0.19  
sqlitedict               2.1.0   

[pamelafox]

Could you instead use the context inside a manager? Here's the example that David gives in the issue about testing:
#1171

And here are some examples of fixtures I use:

https://github.com/pamelafox/flask-db-quiz-example/blob/main/tests/conftest.py

https://github.com/Azure-Samples/azure-flask-postgres-flexible-aca/blob/main/src/tests/local/conftest.py

[supreme-core]

Hi 👋🏻

How are you?

Would I be able to see an example with scoped_session?

I like to understand a bit more why this is not the ideal way to do it now

@pytest.fixture(scope='session')
def app(request):
    """Session-wide test `Flask` application."""
    settings_override = {
        'TESTING': True,
        'SQLALCHEMY_DATABASE_URI': TEST_DATABASE_URI
    }
    app = create_app(__name__, settings_override)

    # Establish an application context before running the tests.
    ctx = app.app_context()
    ctx.push()

    def teardown():
        ctx.pop()

    request.addfinalizer(teardown)
    return app

[RonnyPfannschmidt]

@pytest.fixture(scope='session')
def app(request):
    """Session-wide test `Flask` application."""
    settings_override = {
        'TESTING': True,
        'SQLALCHEMY_DATABASE_URI': TEST_DATABASE_URI
    }
    app = create_app(__name__, settings_override)


    with app.app_context():
      yield app

[supreme-core]

Added!

I am puzzle as to why I am unable to rollback and clean up the changes committed during the test run?

I've been struggling with this for the last two days without viable solution. I don't know what I am missing exactly, please point out what I am doing wrong.

@pytest.fixture(scope="session")
def app():
    """CEUI app pytest fixture."""
    # create flask app
    _app = create_app()
    with _app.app_context():
        yield _app

@pytest.fixture(scope="module")
def db_session(db, app):
    from sqlalchemy.engine import create_engine
    Session = scoped_session(sessionmaker(bind=db.engine))
    db.session = Session()
    connection = db.engine.connect()
    transaction = connection.begin()
    yield db.session

    transaction.rollback()
    connection.close()
    db.session.close()
    Session.remove()

    # Session.close()
    # db.engine.dispose()

I keep getting this message.

self = <SQLAlchemy>, exc = None

    def _teardown_session(self, exc: BaseException | None) -> None:
        """Remove the current session at the end of the request.
    
        :meta private:
    
        .. versionadded:: 3.0
        """
>       self.session.remove()
E       AttributeError: 'Session' object has no attribute 'remove'

[supreme-core]

The key was passing connection to the session maker, and use the factory class directly created by the scoped_session. Also using the context manager with app.app_context()

What I was doing wrong was creating another instance from the factory class.

@pytest.fixture(scope="module")
def db_session(db):
    """Creates a new database session for a test."""
    print(f"Pytest connection is {db.engine}")
    connection = db.engine.connect()
    transaction = connection.begin()
    db.session = scoped_session(
        session_factory=sessionmaker(
            bind=connection,
        )
    )

    yield db.session

    transaction.rollback()
    db.session.rollback()
    db.session.remove()
    db.session.close()
    connection.close()