-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Google Cloud Storage Cache #214
Conversation
All tests passed with my test server.
|
For better code coverage you'll need to configure proper Cloud Storage support to your Travis instance. |
Hi @oittaa, could you rebase your PR against current master and move your backend to |
Sure thing! |
Please, tell me if something needs to be changed, but this pull request should be rebased now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some comments on your PR. Would be cool if you could address the issues I have with this PR.
Removed. You still might want to add a test like I had before. For example JSON can't handle byte strings and they need to be handled as a special case.
|
Feel free to open a new PR for this! |
This is useful in cloud environments where shared disk cache doesn't exist, but the computation takes a lot of resources and the resulted data doesn't fit easily in Memcached or Redis.
I used an abandoned S3 pull request as a starting point. pallets-eco/cachelib#6