Always run messages that have fixes #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Firstly, thanks for this great plugin, it's a huge help to incrementally enabling new lint rules on our code base 🥳
There's one issue we ran into where on our pre commit hook we use this plugin to auto sort imports, however because the fixer affects lines of code that weren't actually changed the fixer never runs and our imports are no longer auto sorted.
The easiest way I could see to fix this is to always run rules that have auto fixes. I think it makes sense to always do this but maybe it should be an option or something? Happy to discuss this more!