-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require forked version of phing-drush-task #82
Conversation
An alternative to this approach is to alias the version of Drush required by |
I've created a new branch based on this work - see PR #85. I found that:
|
Also, it turns out this update breaks backward compatibility! |
The remote branch has been merged, so this should no longer be an issue. I'm going to leave the branch in case anyone was using it. |
Drupal 8.4 requires Symphony 3 which isn't currently supported in Drush 8. See drush-ops/drush#2724 for more. phing-drush-task is locked to drush < 8.1, so I forked it and changed composer.json, but I ran into some composer issues getting the forked library to load. Instead of trying to debug PSR-0 I just rewrite the handful of phing drush commands in the build with straight exec commands which run in the directory set by the build variables.
This also removes
php-todo-finder
https://github.com/nilportugues/php-todo-finder/blob/master/composer.json as it's requiring old Symfony libraries and and doesn't seem to be used.@becw Drupal 8.4 is not installable with our build tools until this or a similar fix is accepted.