-
Notifications
You must be signed in to change notification settings - Fork 889
Feature: Introduce new rule: newline-before-throw #4380
Conversation
Thanks for your interest in palantir/tslint, @ovr! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
50e9cbf
to
600f81f
Compare
600f81f
to
64fa117
Compare
I do not think that the job of tslint is to enforce code formatting standards and am personally questioning if any such rules should exist as the core part of tslint. There is likely a need for a tslint-contrib that is more openly/publicly maintained. I'm going to hold this PR for a bit while we figure out a written policy for which types of rules will be a part of tslint out of the box. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking a request changes to prevent merge while we figure out policy of rules.
readability
👍 Thanks |
This rules seems as logic as the "newline before return" rules already implemented. And as a typescript user, I expect from tslint to check as good my |
@ericanderson @JoshuaKGoldberg @adidahiya Some months since the PR is created and ready to merge. This is labelled as "In discussion", can we help about it ? |
@VincentLanglet @ovr sorry for the delay here, but as per #4534 and #3592, I am inclined to close this PR and avoid adding new formatting rules to core TSLint. This new rule can happily live in a community rule set outside of this repo. |
Hey!
PR checklist
Overview of change:
New rule 😸
CHANGELOG.md entry:
[new-rule]
newline-before-throw
Thanks