Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Output code warnings in yellow instead of red #3402

Merged
merged 2 commits into from
Oct 27, 2017
Merged

Output code warnings in yellow instead of red #3402

merged 2 commits into from
Oct 27, 2017

Conversation

jez9999
Copy link
Contributor

@jez9999 jez9999 commented Oct 26, 2017

Addresses issue #3401.

ajafff
ajafff reviewed Oct 26, 2017
View reviewed changes
src/formatters/codeFrameFormatter.ts
@@ -67,7 +67,7 @@ export class Formatter extends AbstractFormatter {
}

let failureString = failure.getFailure();
failureString = chalk.red(failureString);
failureString = failure.getRuleSeverity() === "warning" ? chalk.yellow(failureString) : chalk.red(failureString);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add a test for this in test/formatters/codeFrameFormatterTests.ts?

@jez9999
Copy link
Contributor Author

jez9999 commented Oct 26, 2017

Added test.

@ajafff ajafff merged commit 965ecb5 into palantir:master Oct 27, 2017
@ajafff
Copy link
Contributor

ajafff commented Oct 27, 2017

thanks @jez9999

This was referenced Oct 27, 2017
Closed
Merged
HyphnKnight pushed a commit to HyphnKnight/tslint that referenced this pull request Apr 9, 2018
@jez9999 @HyphnKnight
Output code warnings in yellow instead of red (palantir#3402)
937c05b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ajafff ajafff ajafff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jez9999 @ajafff