This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Async-ified linterTests.ts #3338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajafff
suggested changes
Oct 17, 2017
| const sourceFile = createSourceFile(templateFile, `${templateDeclaration}`, ScriptTarget.ES2015); | ||
| const replacement = new Replacement(6, 9, ""); | ||
| const failure = new RuleFailure(sourceFile, 6, 15, "Declaration doesn't exist", "foo-bar", replacement); | ||
| linter.applyFixesHelper(componentFile, componentDeclaration(templateFile), [failure]); | ||
| assert.equal(fs.readFileSync(templateFile, "utf-8"), templateDeclarationFixed); | ||
|
|
||
| const actualTemplateFileContents = await readFileAsync(templateFile, "utf-8"); |
There was a problem hiding this comment.
this one makes no sense to be async and awaited immediately
| @@ -213,3 +215,27 @@ export function detectBufferEncoding(buffer: Buffer, length = buffer.length): En | |||
| export function denormalizeWinPath(path: string): string { | |||
| return path.replace(/\\/g, "/"); | |||
| } | |||
|
|
|||
| export async function readFileAsync(fileName: string, encoding: string): Promise<string> { | |||
| return await new Promise<string>((resolve, reject) => { | |||
There was a problem hiding this comment.
same as the other PR: remove the await here
| } | ||
|
|
||
| export async function writeFileAsync(fileName: string, data: string): Promise<void> { | ||
| await new Promise<void>((resolve, reject) => { |
There was a problem hiding this comment.
same as the other PR: replace await with return
I'll just rescind. Thanks for the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Uses asynchronous file reading & writing. Very mild performance boost for writing the test's temp files in parallel.