This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Async-ified writing the tslint.json file in --init #3337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 16, 2017 21:47
The `runWorker` method is already `async`. Added a general purpose `async` wrapper in utils around `fs.writeFile`.
ajafff
suggested changes
Oct 17, 2017
| @@ -213,3 +215,15 @@ export function detectBufferEncoding(buffer: Buffer, length = buffer.length): En | |||
| export function denormalizeWinPath(path: string): string { | |||
| return path.replace(/\\/g, "/"); | |||
| } | |||
|
|
|||
| export async function writeFileAsync(fileName: string, data: string): Promise<void> { | |||
| await new Promise<void>((resolve, reject) => { | |||
There was a problem hiding this comment.
you can simply return the Promise without awaiting
| export async function writeFileAsync(fileName: string, data: string): Promise<void> { | ||
| await new Promise<void>((resolve, reject) => { | ||
| fs.writeFile(fileName, data, (error?: Error) => { | ||
| if (error !== null) { |
There was a problem hiding this comment.
the mixed types here don't make sense. The optional paramter indicates that error may be undefined, but you compare it to null.
I guess consistently using null here is the right thing to do.
Works for me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
runWorkermethod is alreadyasync. Added a general purposeasyncwrapper in utils aroundfs.writeFile.PR checklist
Overview of change:
Uses
fs.readFilewithin anasyncwrapper underutilsinstead offs.readFileSync.