Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

deprecate typeof-compare #3286

Merged
merged 2 commits into from
Oct 19, 2017
Merged

deprecate typeof-compare #3286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb5e86b
deprecate typeof-compare
ajafff Oct 5, 2017
47007e3
Fix error when building docs
ajafff Oct 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ruleLoader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export function loadRules(ruleOptionsList: IOptions[],
rules.push(rule);
}

if (Rule.metadata !== undefined && Rule.metadata.deprecationMessage !== undefined) {
if (Rule.metadata !== undefined && Boolean(Rule.metadata.deprecationMessage)) {
showWarningOnce(`${Rule.metadata.ruleName} is deprecated. ${Rule.metadata.deprecationMessage}`);
}
}
Expand Down
3 changes: 3 additions & 0 deletions src/rules/typeofCompareRule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ export class Rule extends Lint.Rules.AbstractRule {
optionExamples: [true],
type: "functionality",
typescriptOnly: false,
deprecationMessage: ts.versionMajorMinor as string === "2.1"
? "Starting from TypeScript 2.2 the compiler includes this check which makes this rule redundant."
: "",
};
/* tslint:enable:object-literal-sort-keys */

Expand Down