Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Remove .settings directory #2246

Merged
merged 1 commit into from
Feb 27, 2017
Merged

Remove .settings directory #2246

merged 1 commit into from
Feb 27, 2017

Conversation

andy-hanson
Copy link
Contributor

Presumably should have been part of #662?

@DickvdBrink
Copy link
Contributor

I left it in PR 662 because it is not a VSCode file, I thought it was maybe Eclipse or something.
Not sure if it is required though ;)

@andy-hanson
Copy link
Contributor Author

Ah, it says something about Eclipse on the last line.
There's also a .project file.
These haven't been touched in a while -- does Eclipse still use a custom build system for TypeScript? The file has gotten out-of-date; it even specifies compiler.noImplicitAny=false.

adidahiya
adidahiya approved these changes Feb 27, 2017
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feels safe to remove

@adidahiya adidahiya merged commit b683d83 into palantir:master Feb 27, 2017
@renovate-bot renovate-bot mentioned this pull request Feb 27, 2017
Merged
@andy-hanson andy-hanson deleted the rm_settings branch March 1, 2017 00:09
@andy-hanson andy-hanson mentioned this pull request Mar 1, 2017
Merged
@renovate-bot renovate-bot mentioned this pull request Mar 29, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andy-hanson @DickvdBrink @adidahiya