This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Support multiple old-style options. #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit aaa2319.
* Do not use presets; use an algorithm to generate a preset from multiple options.
This can produce complex issues -- if there's a bug in TSLint, it may not lint properly. |
|
That was the idea -- it would fail immediately, rather than after the next publish to NPM. |
|
@andy-hanson thanks for the quick update |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #2041 (comment)
Unreverts #2118 (restores #1957 and #2041).
New changes are at 81266d6 .
I was not aware that the old-style options for
member-orderingsupported more than one option at once. Had to update the code to reflect that.Why don't we always use
./bin/tslintto lint tslint instead of the one in node_modules?