Prepare for v4.4.0 #2109
Prepare for v4.4.0 #2109
Conversation
| * [new-rule-option] `whitespace` adds `check-preblock` option (#2002) | ||
| * [new-rule-option] `member-ordering` adds categories, allowing flexible ordering of different types of members (#2041) | ||
| * [new-rule-option] `strict-boolean-expressions` adds `allow-null-union`, `allow-undefined-union`, `allow-string`, and `allow-number` and (#2033) | ||
| * [new-fixer] `align` (#2097) |
There was a problem hiding this comment.
[new-fixer] no-trailing-whitespace (2060)
| * [bugfix] `no-magic-numbers` false positive on default parameter values (#2004) | ||
| * [bugfix] `no-empty-interface` allow empty interface with 2 or more parents (#2070) | ||
| * [bugfix] `no-trailing-whitespace` fixed for comments and EOF (#2060) | ||
| * [bugfix] `no-empty` no longer fails for private or protected constructor |
| * [bugfix] `no-empty` no longer fails for private or protected constructor | ||
| * [bugfix] `tslint:disable`/`tslint-enable` now handles multiple rules and fixes what code is enabled/disabled (#2061) | ||
| * [bugfix] `no-inferrable-types` now validates property declarations (#2081) | ||
| * [bugfix] `unified-signatures` false positive (#2016) |
There was a problem hiding this comment.
[bugfix] whitespace finds all whitespace errors in JsxExpressions and TemplateExpressions (2036)
[bugfix] comment-format no more false positives in JsxText (2036)
| * [bugfix] `tslint:disable`/`tslint-enable` now handles multiple rules and fixes what code is enabled/disabled (#2061) | ||
| * [bugfix] `no-inferrable-types` now validates property declarations (#2081) | ||
| * [bugfix] `unified-signatures` false positive (#2016) | ||
| * [enhancement] `--test` option now accepts glob |
|
|
||
| // added in v4.4 | ||
| "arrow-return-shorthand": true, | ||
| "no-unbound-method": true, |
There was a problem hiding this comment.
We haven't enabled any other rules that require type information in this config and I don't think we should start now. We could introduce a separate config for type checking rules and perhaps reconsider for the next major release.
|
should |
|
@nchen63 agreed, I would leave it out of the built-in configs |
| "no-unnecessary-initializer": true, | ||
| "no-misused-new ": true, | ||
| "prefer-method-signature": true, | ||
| "prefer-function-over-method": false, |
There was a problem hiding this comment.
don't need this line if you're setting it to disabled
| "arrow-return-shorthand": true, | ||
| "no-unnecessary-initializer": true, | ||
| "no-misused-new ": true, | ||
| "prefer-method-signature": true, |
There was a problem hiding this comment.
let's remove this too; I think it's a little too opinionated and would fail a lot of our builds
hold for
no-let-undefinedtono-unnecessary-initializer#2106await-promiserule #2102