This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 887
Introduce AbstractWalker for performance #2093
Merged
+126
−65
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
da3ac7d
Implement AbstractWalker
ajafff 252599d
Implement WalkContext and Rule.applyWithFunction
ajafff b8ffd67
Refactor no-null-keyword to walk function
ajafff fbe808e
Refactor no-magic-numbers to AbstractWalker
ajafff eacd1a5
PR feedback
ajafff 0d7ae81
Remove languageService property for now
ajafff 5ec78a4
Address review comments
ajafff 0389404
Merge branch 'master' into abstract_walker
ajafff 4662cf1
Restore location of AbstractRule#isEnabled
ajafff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove languageService property for now
commit 0d7ae811427daeaf379ec30341fd97b6169e75ce
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -283,12 +283,9 @@ export class WalkContext<T> { | |
public readonly failures: RuleFailure[]; | ||
private limit: number; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. rename to |
||
|
||
constructor(public readonly sourceFile: ts.SourceFile, | ||
public readonly ruleName: string, | ||
public readonly options: T, | ||
public readonly languageService?: ts.LanguageService) { | ||
constructor(public readonly sourceFile: ts.SourceFile, public readonly ruleName: string, public readonly options: T) { | ||
this.failures = []; | ||
this.limit = sourceFile.getFullWidth(); | ||
this.limit = sourceFile.end; | ||
} | ||
|
||
/** Add a failure with any arbitrary span. Prefer `addFailureAtNode` if possible. */ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, I don't think the generic option helps all that much since it's not constrained and only used by the user