Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Changed --test to take multiple directories #2079

Merged
merged 1 commit into from
Jan 20, 2017
Merged

Changed --test to take multiple directories #2079

merged 1 commit into from
Jan 20, 2017

Conversation

JoshuaKGoldberg
Copy link
Contributor

PR checklist

What changes did you make?

Used an extra glob.sync to allow for wildcards / general glob patterns from --test.

Is there anything you'd like reviewers to focus on?

A couple of issues I think should be addressed before merge:

  • No tests added. I didn't see much coverage for runTest other than the CLI's general exit code testing. I can add exit similar testing for runTests, but is there a more direct testing method you'd like instead?
  • Can part of ruleTestRunner.ts be replaced with runTests?

Copy link
Contributor

@nchen63 nchen63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@nchen63 nchen63 merged commit 85f539f into palantir:master Jan 20, 2017
@JoshuaKGoldberg JoshuaKGoldberg deleted the multiple-tests-from-runner branch January 20, 2017 08:45
@JoshuaKGoldberg
Copy link
Contributor Author

Thanks for the quick merge @nchen63! About the extra points in the PR - I'll look into doing both of those as described unless directed otherwise.

@nchen63
Copy link
Contributor

nchen63 commented Jan 20, 2017

Yep, those are both fine. Make sure all changes to ruleTestsRunner are backwards compatible

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants