Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Fix no-trailing-whitespace for comments and EOF #2060

Merged
merged 1 commit into from
Jan 20, 2017
Merged

Fix no-trailing-whitespace for comments and EOF #2060

merged 1 commit into from
Jan 20, 2017

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Jan 17, 2017

PR checklist

What changes did you make?

Detect trailing whitespace in comments.
Detect trailing whitespace before EOF.
Add fixer.

Is there anything you'd like reviewers to focus on?

(optional)

Copy link
Contributor

@nchen63 nchen63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks

@nchen63
Copy link
Contributor

nchen63 commented Jan 18, 2017

please rebase

@jkillian
Copy link
Contributor

Yay, thanks @ajafff! Was just looking for this feature today

Detect trailing whitespace in comments.
Detect trailing whitespace before EOF.
Add fixer.

Fixes: #2049
@nchen63 nchen63 merged commit 6194bb1 into palantir:master Jan 20, 2017
macklinu added a commit to danger/danger-js that referenced this pull request Jan 25, 2017
A bugfix in TSLint 4.4 revealed a few instances of trailing whitespace
in comments. See palantir/tslint#2060.
macklinu added a commit to danger/danger-js that referenced this pull request Jan 25, 2017
A bugfix in TSLint 4.4 revealed a few instances of trailing whitespace
in comments. See palantir/tslint#2060.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants