This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Refactor walker #1923
Merged
Refactor walker #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods are still available and simply delegate to the utility function to remain backwards compatible. The methods can be removed in the next major version.
AbstractRule now deduplicates and filters failures in disabled intervals
nchen63
suggested changes
Dec 24, 2016
| @@ -0,0 +1,26 @@ | |||
| /** | |||
| * @license | |||
| * Copyright 2013 Palantir Technologies, Inc. | |||
| @@ -68,21 +64,14 @@ export class RuleWalker extends SyntaxWalker { | |||
| } | |||
| } | |||
|
|
|||
| public skip(node: ts.Node) { | |||
There was a problem hiding this comment.
I'm really hope nobody is using this. It looks like it implemented with a bunch of other stuff and never used
There was a problem hiding this comment.
I readded the method.
I will remove this in the followup PR with breaking changes
adidahiya
reviewed
Dec 25, 2016
|
|
||
| import {RuleFailure} from "../rule/rule"; | ||
|
|
||
| export interface IWalker { |
There was a problem hiding this comment.
can we put this in walker/index.ts instead? the import from /.../walker/walker doesn't look as nice as /.../walker
|
@ajafff thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What changes did you make?
See tracking issue #1900
Is there anything you'd like reviewers to focus on?
I made a separate commit for every change. If you want I can submit them as individual PRs.
There will be a followup PR with the breaking changes for cleanup. That includes removing the is*Boundary methods from their classes and only use utility function instead.