This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Treat one-line arrow funcs like a normal statement regarding semicolons #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
reviewed
Nov 7, 2016
| if (initializer && initializer.kind === ts.SyntaxKind.ArrowFunction) { | ||
|
|
||
| // check if this is a multi-line arrow function (`[^]` in the regex matches all characters including CR & LF) | ||
| if (initializer && initializer.kind === ts.SyntaxKind.ArrowFunction && /\{[^]*\n/.test(node.getText())) { |
There was a problem hiding this comment.
this condition is getting pretty long; I think the last test with the regex belongs in its own simple function; that would allow you to move the comment elsewhere as well
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What changes did you make?
Only apply rule of arrows and semicolons on multiline functions
Is there anything you'd like reviewers to focus on?
(optional)