This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Require semicolon for function declaration with no body #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with this, although I'm a little worried because it's technically a breaking change. Think consumers would mind this change? I'd rather not bump a major version for it |
jkillian
added
Status: In Discussion
Type: Breaking Change
and removed
Status: In Discussion
labels
|
Slating this for an upcoming 4.0 release (in a couple weeks probably?) |
|
Great! |
soniro
pushed a commit
to soniro/tslint
that referenced
this pull request
Aug 31, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest that all function declarations without bodies be required to end in a semicolon.
What do you think of this rule?
This would apply to both overloads and to functions in
.d.tsdeclarations.