This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add new Rule: arrow-parens #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /* tslint:disable:object-literal-sort-keys */ | ||
| public static metadata: Lint.IRuleMetadata = { | ||
| ruleName: "arrow-parens", | ||
| description: "Requires parentheses when using arrow function.", |
There was a problem hiding this comment.
Can we change this to: "Requires parentheses around the parameters of arrow function definitions."
|
Looks good @YuichiNukiyama! Mind making the small documentation tweaks mentioned above? |
|
Thanks @jkillian. I did it. |
|
Thanks @YuichiNukiyama! |
soniro
pushed a commit
to soniro/tslint
that referenced
this pull request
Aug 31, 2016
* Add new Rule: arrow-parens * Add test * modify some documentations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impliment #777
Arrow function allow ommit parentheses when parameter is single. This PR enforces parentheses around typeless parameter of arrow function .
This PR doent't warn typed parameter. Becase, TS don't allow ommit parentheses when we use typed parameter. following code, TS warn syntax error and TSLint don't