This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add await-promise rule
#2102
Merged
Add await-promise rule
#2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-hanson
force-pushed
the
await_promise
branch
from
05e6041 to
4eb997b
Compare
IllusionMH
reviewed
Jan 23, 2017
| export class Rule extends Lint.Rules.TypedRule { | ||
| /* tslint:disable:object-literal-sort-keys */ | ||
| public static metadata: Lint.IRuleMetadata = { | ||
| ruleName: "strict-boolean-expressions", |
There was a problem hiding this comment.
Looks like wrong ruleName. Should be await-promise instead of strict-boolean-expressions.
There was a problem hiding this comment.
Good catch!
Can we have a script that uses a template for creating a rule please?
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What changes did you make?
Added the
await-Promiserule, which ensures that anything in anawaitexpression could actually be a Promise. Prevents needlessly awaiting synchronously available values.This is complementary to #1632: That ensures that Promises are awaited, while this ensures that awaiteds are Promises.